fix(Android): improve RN detection in build scripts #2537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WoLewicki
reviewed
Nov 22, 2024
android/build.gradle
Outdated
| } | ||
|
|
||
| // We're in non standard setup - try to use node resolver to locate the react-native package. | ||
| String searchResult = ["node", "--print", "require.resolve('react-native/package.json')"].execute(null, rootDir).text.trim() |
There was a problem hiding this comment.
Suggested change
| String searchResult = ["node", "--print", "require.resolve('react-native/package.json')"].execute(null, rootDir).text.trim() | |
| String searchResult = ["node", "--print", "require.resolve('react-native/package.json')"].execute(null, rootDir).text.trim() | |
| if (searchResult == null || searchResult.isBlank()) { | |
| searchResult = ["node", "--print", "require.resolve('react-native/package.json')"].execute(null, projectDir).text.trim() | |
| } |
WoLewicki
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It has been reported that there are project configurations in which "$projectDir/../node_modules/react-native" exists, but node module resolution algorithm
fails to find it. I've reintroduced the aforementioned location.
Test code and steps to reproduce
Our examples should keep working as always ^^
Checklist